yeah that diagram is correct the man who drew that out has posted a lot of great diagrams I could be wrong but phostenix designed it. Between him, Breja toneworks and guitarelectronics.com (more advanced) and seymour duncan wiring generator on the support part of the page you can learn a lot. If you want to add onto the wiring let me know I must have over 100 diagrams on my computer.
if position 2 when you use the coilsplit hums and you are using a seymour duncan pickup
white - hot lead (switch)
black / green - coilsplit (to push pull)
red / bare - ground
this creates hum cancellation without changing any positions sound. This will not make the pickup go out of phase either.
I personally like how he used one tone capacitor. To me it shows someone knows what they are doing.
Personally I'm a 0.033uf fan but whatever the guitar has should be fine
a replacing at least one pot with 500k can make the guitar brighter if you need it to be. But same as before this is only for serious tone chasing
a cheap way to make the entire guitar brighter - 1950s switch mod premier guitar article. It just changes a wire or two around.
an alternative to adding a push pull pot if you want to experience it without much soldering I suggest is this. Change a tone capacitor to the coilsplit wires from the bridge. That tone control makes the pickup split a coil. This gives you control as 10 is your pickups standard sound. Turning towards 0 splits the coil. At 0 where it will not move any more is the same as if you pulled up on a push pull
black - still the same place
red/white - to where this quickly drawn diagram say to go instead
green/bare - still ground
View attachment 101216