Re: Is this wiring correct? I wired it as recommended it sounded like crap!! Does not
I assume it's meant to be a coil split switch. Red wired to on 1, and white to on 2, for whatever reason instead of black. For a start, right now (sorry if I'm making a stupid mistake), red and white should be both connected to 'on 1', and black to 'on 2'. There's no output in that wiring, guess that should be at the 'off' position, and from there going to the pickup selector. Furthermore, A 2-way on/on switch (or push/pull pot) would make much more sense than a 3-way.
So, I think the volume pot is just illustrated there to make clear where green and bare should be connected to, and that's fine. So I guess you're looking for this: connect green and bare to the "body" of the volume pot, or anywhere else where all those bare wires are soldered to. Leave everything else on the pots alone. Connect red and white to left "on", pickup selector to "off" and black to right "on".
If this is what you're looking for, I suggest using a 2-way switch or push/pull pot, because it gets rid of the useless middle position.
Please correct me if I'm talking rubbish, I've had a few drinks.
edit: the colour codes I'm talking about are Seymour Duncan. If you use another brand, colour codes are different, so it's not going to work this way. Make sure you didn't get the recommendation from a Dimarzio or anything else user, because that would mess it up.