Is there something wrong with this diagram?

[ThomasP]

Hello everybody,

I reproduced this diagram on my guitar and it's not working, there is no sound at all.

Should the switch wire be connected to the "in" of the tone pot and then it goes from the "out" of the tone pot to the "in" of the volume pot?

Thank you,
Thomas

[Bowtomecha]

I’m not seeing anything wrong with the diagram. You have all the grounds wired together right? They have to be connected to complete the path.

the tip is hot and the sleeve is ground so make sure you know which is which.

[GuitarDoc]

Should the switch wire be connected to the "in" of the tone pot and then it goes from the "out" of the tone pot to the "in" of the volume pot?

Absolutely not.

That diagram is correct.

But, as Bowtomecha said, all of the grounds need to be connected. Ground wires from pups, ground lug on switch, back of pots, and sleeve lug at the jack all need to be connected or it won't work.