I do think a lot of people struggle because they just don't have great tools. A weak iron (or a way over-powered one) and a less-than-ideal workspace (& bad lighting) can really impact the quality of the work. Also, if you only do this a few times a year, you simply don't get good at it, and it feels like starting over every time you sit down to work on this sort of thing.
No crime. I was just saying that I bet most of the people here could make it that clean if they really needed/wanted to. Give me a nice tip and an hour, I bet I could come close (after a handful of screwups).

Here's how I do a pot. Bend back the terminal, while gently pushing down so that you don't break the rivet point, then just the minimum amount of solder so that you don't fill the lug hole. Now you have a convenient place to make your ground connections without "toasting" the back of the pot. This is also where I bridge the volume pot to the tone pot with 18 AWG solid wire to make a nice "ground" bridge. All grounds go there. No more connections to the cover of a pot.
That is what my soldering looked like while I was in the military and doing component repair work, however, that was many aeons ago.
Regardless of who, what, when, where, nicely done.
I didn't read a single post in this thread... BUT Why doesn't everyone do work like this?
When I learned, I went to the local Radio Shack, since I was always going there for stuff. The person who worked there played guitar, and told me what to get. I think the fact that we don't have a local electronics store, and a lack of mentors makes learning this skill a little harder.